Skip to content

ci: convert production workflows #3192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 29, 2025
Merged

ci: convert production workflows #3192

merged 14 commits into from
Oct 29, 2025

Conversation

@dreamwasp
Copy link
Contributor

@dreamwasp dreamwasp commented Oct 22, 2025 •
edited by atlassian bot
Loading

Overview

Converts the production workflows from CircleCI to GHA including cacheing. Also configures required checks from CircleCI to Github settings

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: GMT-287
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

I don't really know how to test this. I can make the test below fail to show you the required tests are failing but I do think this is a yolo situation.

I will merge this despite the CircleCi Pipeline failure, I'll disable the pipeline after this is shipped.

PR Links and Envs

N/A

@nx-cloud
Copy link

nx-cloud bot commented Oct 22, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit dd7207a

☁️ Nx Cloud last updated this comment at 2025-10-29 13:48:50 UTC

dreamwasp
dreamwasp commented Oct 23, 2025
View reviewed changes
.github/workflows/automerge.yml
Comment on lines -23 to -31
- name: Wait for CI build
uses: fountainhead/[email protected]
id: wait-for-build
with:
token: ${{ secrets.ACTIONS_GITHUB_TOKEN }}
checkName: build-test
ref: ${{ github.event.pull_request.head.sha || github.sha }}
timeoutSeconds: 1200
intervalSeconds: 30
Copy link
Contributor Author

@dreamwasp dreamwasp Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

changed the required checks to the following, so shouldn't need this anymore

Copy link
Contributor Author

@dreamwasp dreamwasp Oct 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

& pr-title

dreamwasp
dreamwasp commented Oct 23, 2025
View reviewed changes
.github/MIGRATION_SUMMARY.md Outdated
@@ -0,0 +1,156 @@
# CircleCI to GitHub Actions Migration Summary
Copy link
Contributor Author

@dreamwasp dreamwasp Oct 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove before shiupping, but wanted to keep cursors notes for the review

@dreamwasp dreamwasp changed the title robo start, need to review ci: convert production workflows Oct 23, 2025
@dreamwasp dreamwasp marked this pull request as ready for review October 23, 2025 17:14
@dreamwasp dreamwasp requested a review from a team as a code owner October 23, 2025 17:14
jakemhiller
jakemhiller reviewed Oct 23, 2025
View reviewed changes
.github/workflows/deploy-production.yml Outdated
- main

env:
NODE_VERSION: '22.13.1'
Copy link
Member

@jakemhiller jakemhiller Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor but i don't think this is used, we use the version from .nvmrc when we run actions/setup-node

@codecademydev
Copy link
Collaborator

codecademydev commented Oct 29, 2025

📬 Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@dreamwasp dreamwasp requested a review from jakemhiller October 29, 2025 13:51
@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

🚀 Styleguide deploy preview ready!

Preview URL: https://69021c043f76e598b096e0b7--gamut-preview.netlify.app
Deploy Logs: https://app.netlify.com/projects/gamut-preview/deploys/69021c043f76e598b096e0b7

jakemhiller
jakemhiller approved these changes Oct 29, 2025
View reviewed changes
Copy link
Member

@jakemhiller jakemhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dreamwasp dreamwasp added the Ship It :shipit: Automerge this PR when possible label Oct 29, 2025
@codecademydev codecademydev merged commit 96f583a into main Oct 29, 2025
18 of 20 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Oct 29, 2025
@codecademydev codecademydev deleted the cass-GMT-287 branch October 29, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakemhiller jakemhiller jakemhiller approved these changes

@aresnik11 aresnik11 Awaiting requested review from aresnik11 aresnik11 is a code owner automatically assigned from Codecademy/gamut

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dreamwasp @codecademydev @jakemhiller